Skip to content

Resource Graph: adding param to extend query result with subscription and tenant names#9469

Merged
cormacpayne merged 17 commits intoAzure:masterfrom
OlhaTkachenko:AddName
Jul 29, 2019
Merged

Resource Graph: adding param to extend query result with subscription and tenant names#9469
cormacpayne merged 17 commits intoAzure:masterfrom
OlhaTkachenko:AddName

Conversation

@OlhaTkachenko
Copy link

@OlhaTkachenko OlhaTkachenko commented Jun 19, 2019 •
edited
Loading

Description

Checklist

@adxsdkps
Copy link
Collaborator

adxsdkps commented Jun 19, 2019

Can one of the admins verify this patch?

@cormacpayne
Copy link
Member

cormacpayne commented Jun 20, 2019

/azp run

@azure-pipelines
Copy link
Contributor

azure-pipelines bot commented Jun 20, 2019

Azure Pipelines successfully started running 3 pipeline(s).

cormacpayne
cormacpayne suggested changes Jun 20, 2019
View reviewed changes
@chiragg4u chiragg4u added this to the 2019-07-02 milestone Jun 27, 2019
@markcowl
Copy link
Member

markcowl commented Jul 8, 2019 •
edited
Loading

@OlhaTkachenko You will need to submit a cmdlet review for this, here:https://github.com/azure/azure-powershell-cmdlet-review-pr/issues

We need to discuss what the intended change is, and why you need to use types protected in Az.Accounts

@markcowl markcowl removed this from the 2019-07-02 milestone Jul 8, 2019
@cormacpayne
Copy link
Member

cormacpayne commented Jul 15, 2019

@OlhaTkachenko we should be able to continue with this PR once the PR containing the updated Subscriptions client is merged: #9647

@markcowl
Copy link
Member

markcowl commented Jul 18, 2019

@OlhaTkachenko #9647 is merged, please update this PR to consume the new library

@OlhaTkachenko
Copy link
Author

OlhaTkachenko commented Jul 19, 2019

@OlhaTkachenko You will need to submit a cmdlet review for this, here:https://github.com/azure/azure-powershell-cmdlet-review-pr/issues

We need to discuss what the intended change is, and why you need to use types protected in Az.Accounts

Removed the reference. Do I still need to submit this review?

cormacpayne
cormacpayne suggested changes Jul 23, 2019
View reviewed changes
cormacpayne
cormacpayne previously approved these changes Jul 24, 2019
View reviewed changes
@cormacpayne cormacpayne merged commit c763411 into Azure:master Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markcowl markcowl Awaiting requested review from markcowl

1 more reviewer

@cormacpayne cormacpayne cormacpayne approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Waiting for CI :shipit:

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@OlhaTkachenko @adxsdkps @cormacpayne @markcowl @azuresdkci @chiragg4u